Messages in this thread | | | Date | Thu, 14 Jun 2012 16:23:23 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH 2/2 v2][resend] gpio: pcf857x: enable gpio_to_irq() support |
| |
On Thu, Jun 14, 2012 at 12:10:59AM -0700, Kuninori Morimoto wrote: > + for (i = 0; i < gpio->chip.ngpio; i++) > + if (change & BIT(i)) > + generic_handle_irq(irq_find_mapping(gpio->irq_domain, i)); > + You can probably get away with using for_each_set_bit() as well, which would simplify this a bit.
Also, do you not have to worry about masking the parent IRQ while iterating through the dispatch loop?
| |