lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectre: [media] Altera FPGA firmware download module
Hello Igor M. Liplianin,

The patch fa766c9be58b: "[media] Altera FPGA firmware download
module" from Jan 25, 2011, leads to the following warning:
drivers/misc/altera-stapl/altera.c:2204 altera_get_note()
error: strlcpy() 'key' too small (33 vs 256)

drivers/misc/altera-stapl/altera.c
2200 if ((i >= 0) && (i < note_count)) {
2201 status = 0;
2202
2203 if (key != NULL)
2204 strlcpy(key, &p[note_strings +
2205 get_unaligned_be32(
2206 &p[note_table + (8 * i)])],
2207 length);
2208
2209 if (value != NULL)
2210 strlcpy(value, &p[note_strings +
2211 get_unaligned_be32(
2212 &p[note_table + (8 * i) + 4])],
2213 length);
2214
2215 *offset = i + 1;

The problem is that strlcpy() is using 256 as the size of "key" but
actually it is the size of "value". Except that "value" is 257 bytes so
it is an off by one of the size of "value".

It probably doesn't cause a problem, but it upsets the static checkers
and it's pretty ugly.

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-06-14 21:21    [W:0.132 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site