| Date | Thu, 14 Jun 2012 09:38:00 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH -V9 08/15] hugetlb: Make some static variables global |
| |
On Wed 13-06-12 15:57:27, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > > We will use them later in hugetlb_cgroup.c > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Just a nit [...] > +extern int hugetlb_max_hstate;
Maybe we can mark it __read_mostly as it is modified only during initialization and then it is just a constant.
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
|