| Date | Thu, 14 Jun 2012 11:25:40 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH -V9 11/15] hugetlb/cgroup: Add charge/uncharge routines for hugetlb cgroup |
| |
On Wed 13-06-12 15:57:30, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > > This patchset add the charge and uncharge routines for hugetlb cgroup. > We do cgroup charging in page alloc and uncharge in compound page > destructor. Assigning page's hugetlb cgroup is protected by hugetlb_lock. > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
One minor comment [...] > +void hugetlb_cgroup_commit_charge(int idx, unsigned long nr_pages, > + struct hugetlb_cgroup *h_cg, > + struct page *page) > +{ > + if (hugetlb_cgroup_disabled() || !h_cg) > + return; > + > + spin_lock(&hugetlb_lock); > + set_hugetlb_cgroup(page, h_cg); > + spin_unlock(&hugetlb_lock); > + return; > +}
I guess we can remove the lock here because nobody can see the page yet, right?
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
|