Messages in this thread | | | Subject | Re: [PATCH 2/4] x86: Track minimum microcode revision globally v2 | From | Peter Zijlstra <> | Date | Wed, 13 Jun 2012 23:35:21 +0200 |
| |
On Wed, 2012-06-13 at 13:20 -0700, Andi Kleen wrote: > diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c > index 8a2ce8f..b589c7a 100644 > --- a/arch/x86/kernel/microcode_amd.c > +++ b/arch/x86/kernel/microcode_amd.c > @@ -215,6 +215,7 @@ static int apply_microcode_amd(int cpu) > pr_info("CPU%d: new patch_level=0x%08x\n", cpu, rev); > uci->cpu_sig.rev = rev; > c->microcode = rev; > + update_min_microcode(c); > > return 0; > } > diff --git a/arch/x86/kernel/microcode_intel.c b/arch/x86/kernel/microcode_intel.c > index 899057b..63e8a71 100644 > --- a/arch/x86/kernel/microcode_intel.c > +++ b/arch/x86/kernel/microcode_intel.c > @@ -326,6 +326,7 @@ static int apply_microcode(int cpu) > uci->cpu_sig.rev = val[1]; > c->microcode = val[1]; > > + update_min_microcode(c); > return 0; > }
This would really much better live in common code where it can be preemptible in some sites. There really is no need for this to be non-preemptible.
| |