Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] trivial: treewide: remove extra semicolon added by module_init/exit | Date | Tue, 12 Jun 2012 09:56:36 +0930 |
| |
On Mon, 11 Jun 2012 14:20:28 -0700, Stephen Hemminger <shemminger@vyatta.com> wrote: > Given common kernel practice and the fact that only 16% of the uses of > module_init/exit are without semicolon and that other kernel macros don't > include semicolon. > > I recommend going with the majority and common practice... > 1. Fix the 636 places that use module_init()/exit without semicolon to include semicolon > 2. Remove semicolon from module_init()/exit()
Um, yes. He should do exactly what he did.
It's a wart, let's fix it.
Thanks, Rusty. PS. CC's chopped; somewhere in there is a bad address...
| |