Messages in this thread | | | Date | Wed, 30 May 2012 10:30:25 +0300 | From | Jussi Kivilinna <> | Subject | Re: [PATCH] crypto: serpent - add x86_64/avx assembler implementation |
| |
Quoting Andi Kleen <andi@firstfloor.org>:
> > The driver needs CPUID annotations now (since 3.3), so that it can be > autoloaded. Something like: >
Is it really good idea to autoload crypto modules? Currently loading different cipher implementations is handled via module-aliases and cipher priorities. With autoloading by CPUID, crypto-modules would be loaded and be mostly unused. For example, serpent-sse2 would be autoloaded on all x86-64 kernels (well, on those that have it compiled as module => probably most of distros).
IMHO these should be loaded only when needed, as is done with generic i586/x86-64 assembler cipher implementations.
-Jussi
| |