Messages in this thread | | | Date | Wed, 30 May 2012 13:32:35 +0200 | From | Johannes Goetzfried <> | Subject | Re: [PATCH] crypto: serpent - add x86_64/avx assembler implementation |
| |
On Wed, May 30, 2012 at 10:30:25AM +0300, Jussi Kivilinna wrote: > Quoting Andi Kleen <andi@firstfloor.org>: > > > > >The driver needs CPUID annotations now (since 3.3), so that it can be > >autoloaded. Something like: > > > > Is it really good idea to autoload crypto modules? Currently loading > different cipher implementations is handled via module-aliases and > cipher priorities. With autoloading by CPUID, crypto-modules would > be loaded and be mostly unused. For example, serpent-sse2 would be > autoloaded on all x86-64 kernels (well, on those that have it > compiled as module => probably most of distros). > > IMHO these should be loaded only when needed, as is done with > generic i586/x86-64 assembler cipher implementations.
I agree with that. Currently when I boot my PC with a new 3.4 kernel all the ciphers from the intel-aesni module get loaded whether I need them or not. As Jussi stated most people using distros probably won't need the serpent-avx-x86_64 module get loaded automatically, so it's probably better to leave it that way.
| |