Messages in this thread | | | Subject | Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic | From | Steven Rostedt <> | Date | Thu, 03 May 2012 14:54:05 -0400 |
| |
On Thu, 2012-05-03 at 11:43 -0700, Vaibhav Nagarnaik wrote: > On Thu, May 3, 2012 at 7:12 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > > It's also giving me errors when I try to enable events or anything else > > when tracing_on is disabled. > > Yes, I had to add a check to see if resizing is safe. I re-used > record_disabled in this patch for that purpose. > > In the next patch for "atomic addition of pages" I added a new field > resize_disabled to guard against unsafe resizing. So with that patch, > you won't see this behavior. It also fixes the issue with trace-cmd > where the ring buffer doesn't get expanded.
Would it be possible to put that resize_disabled into the first patch so we don't have this bug popping up in a git bisect?
-- Steve
| |