Messages in this thread | | | From | Vaibhav Nagarnaik <> | Date | Thu, 3 May 2012 11:43:22 -0700 | Subject | Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic |
| |
On Thu, May 3, 2012 at 7:12 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > It's also giving me errors when I try to enable events or anything else > when tracing_on is disabled.
Yes, I had to add a check to see if resizing is safe. I re-used record_disabled in this patch for that purpose.
In the next patch for "atomic addition of pages" I added a new field resize_disabled to guard against unsafe resizing. So with that patch, you won't see this behavior. It also fixes the issue with trace-cmd where the ring buffer doesn't get expanded.
Vaibhav Nagarnaik
| |