Messages in this thread Patch in this message | | | Date | Sat, 19 May 2012 19:11:55 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] HID: wacom: Add LED selector control for Wacom Intuos4 WL |
| |
On Fri, 11 May 2012, Jiri Kosina wrote:
> > Add sysfs attribute to control LED selector on Wacom Intuos4. > > Applied, thanks. >
This results in a build failure if you've enabled CONFIG_HID_WACOM without CONFIG_NEW_LEDS, which is required for CONFIG_LEDS_CLASS.
drivers/built-in.o: In function `led_classdev_unregister': (.text+0x3ff685): undefined reference to `led_brightness_set' drivers/built-in.o: In function `led_classdev_unregister': (.text+0x3ff695): undefined reference to `leds_list_lock' drivers/built-in.o: In function `led_classdev_unregister': (.text+0x3ff6ab): undefined reference to `leds_list_lock' drivers/built-in.o: In function `led_classdev_register': (.text+0x3ff6e9): undefined reference to `leds_list_lock' drivers/built-in.o: In function `led_classdev_register': (.text+0x3ff6f5): undefined reference to `leds_list' drivers/built-in.o: In function `led_classdev_register': (.text+0x3ff700): undefined reference to `leds_list' drivers/built-in.o: In function `led_classdev_register': (.text+0x3ff70c): undefined reference to `leds_list_lock'
Please apply the patch below.
hid, wacom: fix build breakage without CONFIG_LEDS_CLASS
CONFIG_HID_WACOM must depend on CONFIG_LEDS_CLASS, otherwise CONFIG_NEW_LEDS may be disabled.
Signed-off-by: David Rientjes <rientjes@google.com> --- drivers/hid/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -613,8 +613,8 @@ config THRUSTMASTER_FF config HID_WACOM tristate "Wacom Bluetooth devices support" depends on BT_HIDP + depends on LEDS_CLASS select POWER_SUPPLY - select LEDS_CLASS ---help--- Support for Wacom Graphire Bluetooth and Intuos4 WL tablets.
| |