lkml.org 
[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] rtc-twl: pass IRQF_ONESHOT to request_threaded_irq
Date
The flag of IRQF_ONESHOT should be passed to request_threaded_irq,
otherwise the following failure message will be dumped because
hardware handler is defined as NULL:

[ 3.329864] genirq: Threaded irq requested with handler=NULL and
!ONESHOT for irq 363
[ 3.338226] twl_rtc twl_rtc: IRQ is not free.
[ 3.346099] twl_rtc: probe of twl_rtc failed with error -22

The patch fixes the rtc-twl probe failure.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
drivers/rtc/rtc-twl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index 258abea..c5d06fe 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
}

ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT,
dev_name(&rtc->dev), rtc);
if (ret < 0) {
dev_err(&pdev->dev, "IRQ is not free.\n");
--
1.7.9.5


\
 
 \ /
  Last update: 2012-05-17 06:21    [W:0.051 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site