lkml.org 
[lkml]   [2012]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH] USB: XHCI: xhci-ring: Remove unused dma address calculation in inc_enq and inc_deq function
Hi,

in xhci-ring.c, function inc_enq and inc_deq calculate the dma address
of trb but never used. This calculation may be used for debugging
purpose, in that case this code should be part of debug flag.

Signed-off-by: Girish Verma <girish@circuitsutra.com>
---
drivers/usb/host/xhci-ring.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 3d9422f..dcd67c1 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -146,7 +146,6 @@ static void next_trb(struct xhci_hcd *xhci,
static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring)
{
union xhci_trb *next;
- unsigned long long addr;

ring->deq_updates++;

@@ -168,7 +167,6 @@ static void inc_deq(struct xhci_hcd *xhci, struct
xhci_ring *ring)
ring->dequeue = ring->deq_seg->trbs;
next = ring->dequeue;
}
- addr = (unsigned long long) xhci_trb_virt_to_dma(ring->deq_seg,
ring->dequeue);
}

/*
@@ -193,7 +191,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct
xhci_ring *ring,
{
u32 chain;
union xhci_trb *next;
- unsigned long long addr;

chain = le32_to_cpu(ring->enqueue->generic.field[3]) & TRB_CHAIN;
/* If this is not event ring, there is one less usable TRB */
@@ -245,7 +242,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct
xhci_ring *ring,
ring->enqueue = ring->enq_seg->trbs;
next = ring->enqueue;
}
- addr = (unsigned long long) xhci_trb_virt_to_dma(ring->enq_seg,
ring->enqueue);
}

/*
--

\
 
 \ /
  Last update: 2012-05-13 03:41    [W:0.071 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site