Messages in this thread | | | Date | Tue, 01 May 2012 11:36:27 +0800 | From | Alex Shi <> | Subject | Re: [PATCH] scsi/mpt2sas: remove unnecesscary preempt requirement for MSIX |
| |
On 04/30/2012 01:29 PM, Nandigama, Nagalakshmi wrote:
> Alex, > I submitted this patch already.
Ok. that's fine.
> > James, request you to pick up the patch that I previously submitted for fixing this issue. Attaching the patch that I submitted previously. > > > Regards, > Nagalakshmi > > > -----Original Message----- > From: Alex Shi [mailto:alex.shi@intel.com] > Sent: Saturday, April 28, 2012 11:58 AM > To: JBottomley@parallels.com; Nandigama, Nagalakshmi > Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; alex.shi@intel.com > Subject: [PATCH] scsi/mpt2sas: remove unnecesscary preempt requirement for MSIX > > smp_processor_id() need used in preempt safe ENV. Otherwise, the > cpu may be preempted and run on other cpus. But here, we don't care much > the specific CPU which handler the MSI, so just replace it by > raw_smp_processor_id() to avoid preempt debug warning. > > Signed-off-by: Alex Shi <alex.shi@intel.com> > --- > drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c > index 8a59a77..3f518ba 100644 > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c > @@ -1785,7 +1785,7 @@ static inline void _base_writeq(__u64 b, volatile void __iomem *addr, > static inline u8 > _base_get_msix_index(struct MPT2SAS_ADAPTER *ioc) > { > - return ioc->cpu_msix_table[smp_processor_id()]; > + return ioc->cpu_msix_table[raw_smp_processor_id()]; > } > > /**
| |