This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Thu Apr 25 17:44:45 2024 Envelope-to: spaans@squeeze.vs19.net Delivery-date: Mon, 30 Apr 2012 07:37:46 +0200 Received: from dspam by squeeze.vs19.net with local (Exim 4.72) (envelope-from ) id 1SOjIv-000704-VC for spaans@squeeze.vs19.net; Mon, 30 Apr 2012 07:37:46 +0200 Received: from na3sys009aog112.obsmtp.com ([74.125.149.207]:50051 "EHLO na3sys009aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309Ab2D3F3b (ORCPT ); Mon, 30 Apr 2012 01:29:31 -0400 Received: from paledge01.lsi.com ([192.19.193.42]) (using TLSv1) by na3sys009aob112.postini.com ([74.125.148.12]) with SMTP ID DSNKT54jOj1Rr2xRrTFb+rVjpfn/rm+E5gSH@postini.com; Sun, 29 Apr 2012 22:29:31 PDT Received: from PALHUB01.lsi.com (128.94.213.114) by PALEDGE01.lsi.com (192.19.193.42) with Microsoft SMTP Server (TLS) id 8.3.213.0; Mon, 30 Apr 2012 01:34:50 -0400 Received: from inbexch02.lsi.com (135.36.98.40) by PALHUB01.lsi.com (128.94.213.114) with Microsoft SMTP Server (TLS) id 8.3.213.0; Mon, 30 Apr 2012 01:29:29 -0400 Received: from inbmail02.lsi.com ([135.36.98.34]) by inbexch02.lsi.com ([135.36.98.40]) with mapi; Mon, 30 Apr 2012 10:59:26 +0530 From: "Nandigama, Nagalakshmi" To: Alex Shi , "JBottomley@parallels.com" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Mon, 30 Apr 2012 10:59:24 +0530 Subject: RE: [PATCH] scsi/mpt2sas: remove unnecesscary preempt requirement for MSIX Thread-Topic: [PATCH] scsi/mpt2sas: remove unnecesscary preempt requirement for MSIX Thread-Index: Ac0lCCp7uVe8ls9kQYWHtgaSjQW9GABiazbQ Message-Id: References: <1335594453-30679-1-git-send-email-alex.shi@intel.com> In-Reply-To: <1335594453-30679-1-git-send-email-alex.shi@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/mixed; boundary="_002_A6888A6805518E4EA4AF7072A28264A6067E92EA43inbmail02lsic_" Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-Natty-Dspam: scanned by squeeze.vs19.net, Mon, 30 Apr 2012 07:29:36 +0200 X-DSPAM-Result: Innocent X-DSPAM-Processed: Mon Apr 30 07:37:45 2012 X-DSPAM-Confidence: 0.9997 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 4f9e2529262851236518775 X-DSPAM-Factors: 27, Received*id+#+#+rfc822, 0.00010, Received*from+#+#+#+EHLO, 0.00010, Received*envelope-from+linux-kernel-owner, 0.00010, Received*vger.kernel.org+via, 0.00010, Received*rfc822+#+vger.kernel.org, 0.00010, Received*ORCPT+#+#+lkml.org, 0.00010, Received* --_002_A6888A6805518E4EA4AF7072A28264A6067E92EA43inbmail02lsic_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Alex,=20 I submitted this patch already.=20 James, request you to pick up the patch that I previously submitted for fix= ing this issue. Attaching the patch that I submitted previously. Regards, Nagalakshmi -----Original Message----- From: Alex Shi [mailto:alex.shi@intel.com]=20 Sent: Saturday, April 28, 2012 11:58 AM To: JBottomley@parallels.com; Nandigama, Nagalakshmi Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; alex.shi@inte= l.com Subject: [PATCH] scsi/mpt2sas: remove unnecesscary preempt requirement for = MSIX smp_processor_id() need used in preempt safe ENV. Otherwise, the cpu may be preempted and run on other cpus. But here, we don't care much the specific CPU which handler the MSI, so just replace it by raw_smp_processor_id() to avoid preempt debug warning. Signed-off-by: Alex Shi --- drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt= 2sas_base.c index 8a59a77..3f518ba 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_base.c +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c @@ -1785,7 +1785,7 @@ static inline void _base_writeq(__u64 b, volatile voi= d __iomem *addr, static inline u8 _base_get_msix_index(struct MPT2SAS_ADAPTER *ioc) { - return ioc->cpu_msix_table[smp_processor_id()]; + return ioc->cpu_msix_table[raw_smp_processor_id()]; } =20 /** --=20 1.7.5.4 --_002_A6888A6805518E4EA4AF7072A28264A6067E92EA43inbmail02lsic_ Content-Type: message/rfc822 Received: from inbmail02.lsi.com ([135.36.98.34]) by inbexch02.lsi.com ([135.36.98.40]) with mapi; Fri, 27 Apr 2012 16:09:31 +0530 From: "Nandigama, Nagalakshmi" To: "Nandigama, Nagalakshmi" , "stable@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "Prakash, Sathya" , "Moore, Eric" CC: "jejb@kernel.org" Date: Fri, 27 Apr 2012 16:09:16 +0530 Subject: RE: [PATCH] [SCSI] mpt2sas : Fix unsafe using smp_processor_id() in preemptible Thread-Topic: [PATCH] [SCSI] mpt2sas : Fix unsafe using smp_processor_id() in preemptible Thread-Index: Ac0cXnM8pd70QzkTSlG9iySK5/0NiAIAyAzA Message-ID: References: <201204170553.q3H5rgCl016528@milmhbs0.lsil.com> In-Reply-To: <201204170553.q3H5rgCl016528@milmhbs0.lsil.com> Accept-Language: en-US Content-Language: en-US X-MS-Exchange-Organization-AuthAs: Internal X-MS-Exchange-Organization-AuthMechanism: 04 X-MS-Exchange-Organization-AuthSource: inbexch02.lsi.com X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 James, this patch is not picked up for 3.5. Request you to push this patch = for next release. Regards, Nagalakshmi -----Original Message----- From: nagalakshmi.nandigama@lsi.com [mailto:nagalakshmi.nandigama@lsi.com] Sent: Tuesday, April 17, 2012 11:25 AM To: stable@vger.kernel.org; linux-scsi@vger.kernel.org; Nandigama, Nagalaks= hmi; Prakash, Sathya; Moore, Eric Cc: jejb@kernel.org Subject: [PATCH] [SCSI] mpt2sas : Fix unsafe using smp_processor_id() in pr= eemptible When CONFIG_DEBUG_PREEMPT is enabled, bug is observed in the smp_processor_= id(). This is because smp_processor_id() is not called in preempt safe condition. To fix this issue, use raw_smp_processor_id instead of smp_processor_id. Signed-off-by: Nagalakshmi Nandigama CC: stable@vger.kernel.org --- diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt= 2sas_base.c index 272fab7..b010be0 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_base.c +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c @@ -1792,7 +1792,7 @@ static inline void _base_writeq(__u64 b, volatile voi= d __iomem *addr, static inline u8 _base_get_msix_index(struct MPT2SAS_ADAPTER *ioc) { - return ioc->cpu_msix_table[smp_processor_id()]; + return ioc->cpu_msix_table[raw_smp_processor_id()]; } /** --_002_A6888A6805518E4EA4AF7072A28264A6067E92EA43inbmail02lsic_-- --: To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org: More majordomo info at http: //vger.kernel.org/majordomo-info.html Please read the FAQ at http: //www.tux.org/lkml/