Messages in this thread Patch in this message | | | Subject | [PATCH] lib/kobject.c : Remove redundant check in create_dir | From | yan <> | Date | Fri, 20 Apr 2012 21:25:53 +0800 |
| |
create_dir is a static function used only in kobject_add_internal. There's no need to do check here, for kobject_add_internal will reject kobject with invalid name.
Signed-off-by: Yan Hong <clouds.yan@gmail.com> --- lib/kobject.c | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/kobject.c b/lib/kobject.c index aeefa8b..38fcc60 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -47,13 +47,11 @@ static int populate_dir(struct kobject *kobj) static int create_dir(struct kobject *kobj) { int error = 0; - if (kobject_name(kobj)) { - error = sysfs_create_dir(kobj); - if (!error) { - error = populate_dir(kobj); - if (error) - sysfs_remove_dir(kobj); - } + error = sysfs_create_dir(kobj); + if (!error) { + error = populate_dir(kobj); + if (error) + sysfs_remove_dir(kobj); } return error; } -- 1.7.5.1
| |