Messages in this thread | | | Date | Thu, 19 Apr 2012 19:36:43 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v4 3/3] cred: change keyctl_session_to_parent() to use task_work_add() |
| |
forgot to mention...
On 04/19, Oleg Nesterov wrote: > On 04/19, David Howells wrote: > > > > Oleg Nesterov <oleg@redhat.com> wrote: > > > > > +#define key_replace_session_keyring() do { } while (0) > > > + > > > > Ummm... Why? You've made the function no longer exist and so this shouldn't be > > there anymore. You shouldn't just leave the call sites in place. > > Sure! > > I'll send the (trivial) patches to cleanup the code in arch/ (24 callers), > plus we should kill the no longer used task ->replacement_session_keyring > and update copy_creds/exit_creds.
... and we should kill tracehook_notify_resume()
> But I certainly do not want to put these changes in 3/3 or in this series. > I'll send the patches to Andrew once (I hope ;) he takes 1-3.
Yes.
Oleg.
| |