Messages in this thread | | | Date | Thu, 19 Apr 2012 20:40:13 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v4 3/3] cred: change keyctl_session_to_parent() to use task_work_add() |
| |
On 04/19, Oleg Nesterov wrote: > > On 04/19, David Howells wrote: > > > > Oleg Nesterov <oleg@redhat.com> wrote: > > > > > But I certainly do not want to put these changes in 3/3 or in this series. > > > > Why not? It seems the correct place for them. > > I wanted to discuss the functional changes first, then send the trivial > cleanups. And the changes in arch/ are always painful. And, "remove > tracehook_notify_resume" is a bit off-topic, but I do not want to change > the same code in arch/ twice.
That said, if you do not agree with 3/3 without "remove the call sites", I'll send v6 which doesn't rename key_replace_session_keyring() but updates the old callers:
arch/alpha/kernel/signal.c | 2 - arch/arm/kernel/signal.c | 2 - arch/avr32/kernel/signal.c | 2 - arch/blackfin/kernel/signal.c | 2 - arch/c6x/kernel/signal.c | 2 - arch/cris/kernel/ptrace.c | 2 - arch/frv/kernel/signal.c | 2 - arch/h8300/kernel/signal.c | 2 - arch/hexagon/kernel/signal.c | 3 +- arch/ia64/kernel/process.c | 2 - arch/m32r/kernel/signal.c | 2 - arch/mips/kernel/signal.c | 2 - arch/mn10300/kernel/signal.c | 2 - arch/openrisc/kernel/signal.c | 2 - arch/parisc/kernel/signal.c | 2 - arch/powerpc/kernel/signal.c | 2 - arch/s390/kernel/signal.c | 2 - arch/sh/kernel/signal_32.c | 2 - arch/sh/kernel/signal_64.c | 2 - arch/sparc/kernel/signal_32.c | 2 - arch/sparc/kernel/signal_64.c | 2 - arch/tile/kernel/process.c | 2 - arch/unicore32/kernel/signal.c | 2 - arch/x86/kernel/signal.c | 2 - include/linux/key.h | 4 -- include/linux/sched.h | 2 - kernel/cred.c | 9 ----- security/keys/internal.h | 2 + security/keys/keyctl.c | 73 +++++++++++++++++++--------------------- security/keys/process_keys.c | 20 ++++------- 30 files changed, 45 insertions(+), 114 deletions(-)
I am not going to argue, but honestly I don't think it is a good idea to mix the functional changes in keyctl.c and the simple (but obviously untested) cleanups.
Oleg.
| |