Messages in this thread Patch in this message | | | From | H Hartley Sweeten <> | Subject | [PATCH] drivers/scs/scsi_sysfs.c: local variables should not be exposed globally | Date | Mon, 16 Apr 2012 18:32:18 -0700 |
| |
Variables not referenced outside of a source file should be marked static to prevent it from being exposed globally.
This quiets the sparse warnings:
warning: symbol 'dev_attr_hstate' was not declared. Should it be static? warning: symbol 'scsi_shost_attr_group' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
---
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 04c2a27..fbff014 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -197,7 +197,7 @@ show_shost_state(struct device *dev, struct device_attribute *attr, char *buf) } /* DEVICE_ATTR(state) clashes with dev_attr_state for sdev */ -struct device_attribute dev_attr_hstate = +static struct device_attribute dev_attr_hstate = __ATTR(state, S_IRUGO | S_IWUSR, show_shost_state, store_shost_state); static ssize_t @@ -313,7 +313,7 @@ static struct attribute *scsi_sysfs_shost_attrs[] = { NULL }; -struct attribute_group scsi_shost_attr_group = { +static struct attribute_group scsi_shost_attr_group = { .attrs = scsi_sysfs_shost_attrs, };
| |