Messages in this thread Patch in this message | | | From | Miklos Szeredi <> | Subject | [PATCH 1/9] vfs: fix double put after complete_walk() | Date | Tue, 6 Mar 2012 13:56:33 +0100 |
| |
From: Miklos Szeredi <mszeredi@suse.cz>
complete_walk() already puts nd->path, no need to do it again at cleanup time.
This would result in Oopses if triggered, apparently the codepath is not too well exercised.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> CC: stable@vger.kernel.org --- fs/namei.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c index e2ba628..f79aef1 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2261,7 +2261,7 @@ static struct file *do_last(struct nameidata *nd, struct path *path, /* Why this, you ask? _Now_ we might have grown LOOKUP_JUMPED... */ error = complete_walk(nd); if (error) - goto exit; + return ERR_PTR(error); error = -EISDIR; if (S_ISDIR(nd->inode->i_mode)) goto exit; -- 1.7.7
| |