Messages in this thread | | | Date | Tue, 20 Mar 2012 12:39:22 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 8/9] vfs: split __lookup_hash |
| |
On Tue, Mar 06, 2012 at 01:56:40PM +0100, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@suse.cz> > > Split __lookup_hash into two component functions: > > lookup_dcache - tries cached lookup, returns whether real lookup is needed > lookup_real - calls i_op->lookup > > This eliminates code duplication between d_alloc_and_lookup() and > d_inode_lookup().
The return value from lookup_dcache is a bit confusing. What about returning the need_lookup flag, and passing the dentry as a parameter, that way the callers would do the more obvious:
if (lookup_dcache(name, base, nd, &dentry)) return dentry;
instead of having to check two conditions.
| |