Messages in this thread | | | Date | Fri, 30 Mar 2012 18:10:57 +0800 | From | Ren Mingxin <> | Subject | Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() |
| |
Hi, James:
On 03/30/2012 05:56 PM, James Bottomley wrote: > On Fri, 2012-03-30 at 17:50 +0800, Ren Mingxin wrote: >> This patch series renames "sd_format_disk_name()" to >> "disk_name_format()" and moves it into block core. So >> that who needs formatting disk name can use it, instead >> of duplicating these similar help functions. >> >> Ren Mingxin (4): >> block: add function disk_name_format() into block core >> scsi: replace sd_format_disk_name() to disk_name_format() > These two should be a single patch so it makes it obvious to anyone > looking through the change sets that the code is merely being moved.
Thank you very much for so quick checking. I'll merge these two patches into one in the next version.
> Other than that, everything looks fine to me. > >
Thanks, Ren
| |