lkml.org 
[lkml]   [2012]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming
      On 03/30/2012 11:38 PM, Tejun Heo wrote:
    > On Fri, Mar 30, 2012 at 08:26:06AM -0700, Tejun Heo wrote:
    >> On Fri, Mar 30, 2012 at 05:53:52PM +0800, Ren Mingxin wrote:
    >>> The current virtblk's naming algorithm only supports 263 disks.
    >>> If there are mass of virtblks(exceeding 263), there will be disks
    >>> with the same name.
    >>>
    >>> By renaming "sd_format_disk_name()" to "disk_name_format()"
    >>> and moving it into block core, virtio_blk can use this function to
    >>> support mass of disks.
    >>>
    >>> Signed-off-by: Ren Mingxin<renmx@cn.fujitsu.com>
    >> I guess it's already way too late but why couldn't they have been
    >> named vdD-P where both D and P are integers denoting disk number and
    > So, if a device name ends in digit the partition code adds delimiter
    > 'p' automatically and this is already in use by md. So, partitioned
    > md devices are named mdDpP where D and P are base 10 number indicating
    > the sequence like md12p4. So, let's please add comment that new
    > drivers should name their devices PREFIX%d where the sequence number
    > can be allocated by ida.
    >
    >

    Oh, got it. Just like md devices' names.

    --
    Thanks,
    Ren



    \
     
     \ /
      Last update: 2012-04-02 03:21    [W:5.015 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site