Messages in this thread Patch in this message | | | Date | Thu, 29 Mar 2012 21:51:19 +0300 | From | Dan Carpenter <> | Subject | [patch] blkcg: change a spin_lock() to spin_lock_irq() |
| |
Smatch complains that we re-enable IRQs twice. It looks like we forgot to disable them here on the spin_trylock() failure path. This was added in 9f13ef678e "blkcg: use double locking instead of RCU for blkg synchronization".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 74a76a8..bf4b76e 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1598,7 +1598,7 @@ static int blkiocg_pre_destroy(struct cgroup *cgroup) } else { spin_unlock_irq(&blkcg->lock); cpu_relax(); - spin_lock(&blkcg->lock); + spin_lock_irq(&blkcg->lock); } }
| |