Messages in this thread | | | Date | Thu, 29 Mar 2012 19:26:19 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] ftrace: Remove a superfluous check |
| |
On Thu, Mar 29, 2012 at 07:17:19PM +0200, John Kacur wrote:
> It looks okay to me. Technically it's not functionally equivalent > though, because now when __register_ftrace_function is called > directly, (in other paths), the test has an unlikely there.
I know, but ftrace_disabled is really unlikely to be set to 1 because we set it only if ftrace_init() fails and on the panic path in ftrace_kill().
So I agree that it is not functionally completely equivalent but it should be correct with the unlikely.
> See what teven says, otherwise, you can have my reviewed by.
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |