Messages in this thread | | | Subject | Re: [PATCH] ftrace: Remove a superfluous check | From | Steven Rostedt <> | Date | Thu, 29 Mar 2012 13:23:54 -0400 |
| |
On Thu, 2012-03-29 at 19:17 +0200, John Kacur wrote: >
> It looks okay to me. Technically it's not functionally equivalent though, > because now when __register_ftrace_function is called directly, (in other > paths), the test has an unlikely there. See what Steven says, otherwise, > you can have my reviewed by.
Unlikely()s shouldn't affect things functionally, its just an optimization hint.
Also, this check is unlikely to be true, so the hint is valid here.
-- Steve
| |