lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ftrace: Remove a superfluous check
From
Date
On Thu, 2012-03-29 at 19:17 +0200, John Kacur wrote:
>

> It looks okay to me. Technically it's not functionally equivalent though,
> because now when __register_ftrace_function is called directly, (in other
> paths), the test has an unlikely there. See what Steven says, otherwise,
> you can have my reviewed by.

Unlikely()s shouldn't affect things functionally, its just an
optimization hint.

Also, this check is unlikely to be true, so the hint is valid here.

-- Steve




\
 
 \ /
  Last update: 2012-03-29 19:27    [W:0.118 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site