lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectOn patch "Remove all #inclusions of asm/system.h"
Hi David,

commit 9ffc93f2 "Remove all #inclusions of asm/system.h" removes a lot of
includes while its parent commit 96f951ed "Add #includes needed to permit
the removal of asm/system.h" adds only a few. Some of the files modified
by commit 9ffc93f2 now only work due to indirect inclusion, don't they?

For example, drivers/firewire/{core-device,core-topology,ohci,sbp2}.c use
smp_rmb()¹ and used to include asm/system.h. Now they do not include
asm/barrier.h. Is this by mistake or on purpose?

(I only noticed the commit come in; I did not get any build error yet.
The mentioned files now get asm/barrier.h via linux/spinlock.h and
certainly via other ways as well.)

--------
¹) so does drivers/firewire/net.c but it missed to include asm/system.h
--
Stefan Richter
-=====-===-- --== ===-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-29 15:37    [W:0.066 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site