Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Check for quoted strings broken across lines | From | Joe Perches <> | Date | Tue, 20 Mar 2012 21:35:58 -0700 |
| |
On Tue, 2012-03-20 at 21:28 -0700, Josh Triplett wrote: > On Tue, Mar 20, 2012 at 06:24:16PM -0700, Joe Perches wrote: > > I don't recall seeing your patch before, but I submitted > > a similar one that I believe Andrew has in his tree. > You reviewed my patch at the time and provided feedback, and I'd > produced a revised version based on that feedback.
duh.
I heard short term memory fades as you get age, but I might not remember that in awhile.
> The heuristics in the patch I submitted almost completely eliminate > false positives, which makes my patch suitable for use without --strict.
Yup, this patch is better than the one I submitted.
One improvement might be to check for a line continuation \ on $prevline and still produce a warning in that case.
cheers, Joe
| |