lkml.org 
[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] checkpatch: Check for quoted strings broken across lines
    From
    Date
    On Tue, 2012-03-20 at 23:05 -0700, Josh Triplett wrote:
    > On Tue, Mar 20, 2012 at 09:35:58PM -0700, Joe Perches wrote:
    > > One improvement might be to check for a line continuation \
    > > on $prevline and still produce a warning in that case.
    >
    > I'd suggest doing that one as a separate check, "unnecessary line
    > continuation", which should flag any use of a line continuation other
    > than with a preprocessor directive. I don't think combining that with
    > the wrapped-string check makes sense.

    What I suggested is for a case in a #define:

    #define subsystem_printk(subsystem, level, format, ...) \
    netdev_printk(level, (subsystem)->dev, "Some partial format " \
    "continued on another line" format, \
    ##__VA_ARGS__)

    where it's necessary to use line continuations but rewrapping like:

    #define subsystem_printk(subsystem, level, format, ...) \
    netdev_printk(level, (subsystem)->dev, \
    "A coalesced format on a single line" format, \
    ##__VA_ARGS__)

    might improve it.

    Anyway:

    Acked-by: Joe Perches <joe@perches.com>




    \
     
     \ /
      Last update: 2012-03-21 13:13    [W:4.106 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site