Messages in this thread | | | Date | Wed, 14 Mar 2012 11:19:10 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 7/7] arch/unicore32/kernel/dma.c: ensure arguments to request_irq and free_irq are compatible |
| |
On Wed, Mar 14, 2012 at 04:07:24PM +0800, Guan Xuetao wrote: > puv3_init_dma() is called ONCE when initializing. > In logical, if request_irq(IRQ_DMAERR, *) failed, free_irq(IRQ_DMA, *) > is unnecessary, and dma device/driver can keep on working. > The patch could be: > ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL); > if (ret) { > printk(KERN_CRIT "Can't register IRQ for DMAERR\n"); > - free_irq(IRQ_DMA, "DMA"); > return ret; > }
It seems like you should remove the error return as well?
regards, dan carpenter
[unhandled content-type:application/pgp-signature] | |