Messages in this thread | | | Subject | Re: [PATCH 7/7] arch/unicore32/kernel/dma.c: ensure arguments to request_irq and free_irq are compatible | From | Guan Xuetao <> | Date | Wed, 14 Mar 2012 16:42:55 +0800 |
| |
On Wed, 2012-03-14 at 11:19 +0300, Dan Carpenter wrote: > On Wed, Mar 14, 2012 at 04:07:24PM +0800, Guan Xuetao wrote: > > puv3_init_dma() is called ONCE when initializing. > > In logical, if request_irq(IRQ_DMAERR, *) failed, free_irq(IRQ_DMA, *) > > is unnecessary, and dma device/driver can keep on working. > > The patch could be: > > ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL); > > if (ret) { > > printk(KERN_CRIT "Can't register IRQ for DMAERR\n"); > > - free_irq(IRQ_DMA, "DMA"); > > return ret; > > } > > It seems like you should remove the error return as well? > > regards, > dan carpenter > The error return value will only generate an extra warning message, and have no side-effect.
Thanks and Regards, Guan Xuetao
| |