Messages in this thread Patch in this message | | | From | David Ahern <> | Subject | [PATCH] perf-record: no build id option fails | Date | Mon, 6 Feb 2012 15:27:52 -0700 |
| |
A recent refactoring of perf-record introduced the following:
perf record -a -B Couldn't generating buildids. Use --no-buildid to profile anyway. sleep: Terminated
I believe the triple negative was meant to be only a double negative. :-) While I'm there, fixed the grammar on the error message.
Signed-off-by: David Ahern <dsahern@gmail.com> --- tools/perf/builtin-record.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 32870ee..47a0055 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -504,9 +504,9 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv) return err; } - if (!!rec->no_buildid + if (!rec->no_buildid && !perf_header__has_feat(&session->header, HEADER_BUILD_ID)) { - pr_err("Couldn't generating buildids. " + pr_err("Couldn't generate buildids. " "Use --no-buildid to profile anyway.\n"); return -1; } -- 1.7.7.6
| |