Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation | From | Joe Perches <> | Date | Fri, 03 Feb 2012 18:46:20 -0800 |
| |
On Fri, 2012-02-03 at 18:40 -0800, Eric W. Biederman wrote: > Joe Perches <joe@perches.com> writes: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > > @@ -1924,6 +1924,12 @@ sub process { [] > > + > > + if ($line =~ /^\+\t{6,}/) { > > + WARN("DEEP_INDENTATION", > > + "Too many leading tabs - consider code refactoring\n" . $herecurr); > > + } > By any chance have you run this patch against itself?
Nope. perl isn't a c. Logic doesn't apply. Some might claim perl logic an oxymoron.
checkpatch should be used for c sources only.
> I find it comical > that there is a line 104 characters long suggesting people use shorter > lines.
You're welcome to line wrap it if you like... I don't actually use checkpatch much.
cheers, Joe
| |