Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 3 Feb 2012 17:27:36 -0800 | Subject | Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation |
| |
On Fri, Feb 3, 2012 at 3:20 PM, Joe Perches <joe@perches.com> wrote: > Overly indented code should be refactored. > > Suggest refactoring excessive indentation of > of if/else/for/do/while/switch statements.
I hate this patch.
Why? Because mindless checks like this would just lead to people making things worse and intermixing spaces there instead.
That's the same reason the 80-character check has been a total disaster. People shut it up by splitting long strings etc, and we've had to change that 80-character test many times just to avoid the crazy workarounds.
Don't warn about things that will just result in people working around the warnings with worse code!
Linus
| |