Messages in this thread Patch in this message | | | From | Sasha Levin <> | Subject | [PATCH] rc-core: don't return from store_protocols without releasing device mutex | Date | Sat, 8 Dec 2012 07:50:50 -0500 |
| |
Commit c003ab1b ("[media] rc-core: add separate defines for protocol bitmaps and numbers") has introduced a bug which allows store_protocols() to return without releasing the device mutex it's holding.
Doing that would cause infinite hangs waiting on device mutex next time around.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com> --- drivers/media/rc/rc-main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 601d1ac1..0510f4d 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -890,7 +890,8 @@ static ssize_t store_protocols(struct device *device, if (i == ARRAY_SIZE(proto_names)) { IR_dprintk(1, "Unknown protocol: '%s'\n", tmp); - return -EINVAL; + ret = -EINVAL; + goto out; } count++; -- 1.8.0
| |