Messages in this thread Patch in this message | | | Date | Fri, 7 Dec 2012 09:19:43 +0300 | From | Dan Carpenter <> | Subject | [patch] aoe: use after free in aoedev_by_aoeaddr() |
| |
We should return NULL on failure instead of returning a freed pointer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index e66ccbf..98f2965 100644 --- a/drivers/block/aoe/aoedev.c +++ b/drivers/block/aoe/aoedev.c @@ -461,6 +461,7 @@ aoedev_by_aoeaddr(ulong maj, int min, int do_alloc) d->targets = kcalloc(NTARGETS, sizeof(*d->targets), GFP_ATOMIC); if (!d->targets) { kfree(d); + d = NULL; goto out; } d->ntargets = NTARGETS;
| |