Messages in this thread Patch in this message | | | Subject | [PATCH RFT] spi: spi-xcomm: Fix wrong setting for SPI_XCOMM_SETTINGS_CPHA | From | Axel Lin <> | Date | Tue, 04 Dec 2012 14:27:41 +0800 |
| |
The logic of setting SPI_XCOMM_SETTINGS_CPHA bit is reversed.
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Hi Lars, The logic of setting SPI_XCOMM_SETTINGS_CPHA bit looks wrong to me. Can you check if this patch works?
Thanks, Axel
drivers/spi/spi-xcomm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-xcomm.c b/drivers/spi/spi-xcomm.c index 266a847..c2a3e8f 100644 --- a/drivers/spi/spi-xcomm.c +++ b/drivers/spi/spi-xcomm.c @@ -99,9 +99,9 @@ static int spi_xcomm_setup_transfer(struct spi_xcomm *spi_xcomm, *settings &= ~SPI_XCOMM_SETTINGS_CPOL; if (spi->mode & SPI_CPHA) - *settings &= ~SPI_XCOMM_SETTINGS_CPHA; - else *settings |= SPI_XCOMM_SETTINGS_CPHA; + else + *settings &= ~SPI_XCOMM_SETTINGS_CPHA; if (spi->mode & SPI_3WIRE) *settings |= SPI_XCOMM_SETTINGS_3WIRE; -- 1.7.9.5
| |