lkml.org 
[lkml]   [2012]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] mm, bootmem: panic in bootmem alloc functions even if slab is available
On Fri, 28 Dec 2012, Pekka Enberg wrote:

> On Sun, 23 Dec 2012, Sasha Levin wrote:
> >> diff --git a/mm/bootmem.c b/mm/bootmem.c
> >> index 1324cd7..198a92f 100644
> >> --- a/mm/bootmem.c
> >> +++ b/mm/bootmem.c
> >> @@ -763,9 +763,6 @@ void * __init ___alloc_bootmem_node(pg_data_t *pgdat, unsigned long size,
> >> void * __init __alloc_bootmem_node(pg_data_t *pgdat, unsigned long size,
> >> unsigned long align, unsigned long goal)
> >> {
> >> - if (WARN_ON_ONCE(slab_is_available()))
> >> - return kzalloc_node(size, GFP_NOWAIT, pgdat->node_id);
> >> -
> >> return ___alloc_bootmem_node(pgdat, size, align, goal, 0);
> >> }
>
> I'm not sure what Sasha's patch is trying to do here but the fall-back
> is there simply to let the caller know it's calling the bootmem
> allocator *too late*. That is, the slab allocator is already up and
> running so you're expected to use that.
>

The __alloc_bootmem_node() variant is intended to panic rather than return
NULL so there are callers that do not check the return value. I'm
suggesting rather than removing the fallback to the slab allocator to
check the return value and panic() here if kzalloc_node() returns NULL.
The __alloc_bootmem_node_nopanic() variant needs not be changed.


\
 
 \ /
  Last update: 2012-12-28 00:01    [W:0.068 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site