Messages in this thread Patch in this message | | | Subject | [PATCH 5/5] fuse: fix synchronous case of fuse_file_put() | From | Maxim Patlasov <> | Date | Thu, 20 Dec 2012 16:32:49 +0400 |
| |
If fuse_file_put() is called with sync==true, the user may be blocked for a while, until userspace ACKs our FUSE_RELEASE request. This blocking must be uninterruptible. Otherwise request could be interrupted, but file association in user space remains.
Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com> --- fs/fuse/file.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index dac3a7c..e6770b8 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -126,6 +126,10 @@ static void fuse_file_put(struct fuse_file *ff, bool sync) struct fuse_req *req = ff->reserved_req; if (sync) { + /* Must force. Otherwise request could be interrupted, + * but file association in user space remains. + */ + req->force = 1; fuse_request_send(ff->fc, req); path_put(&req->misc.release.path); fuse_put_request(ff->fc, req);
| |