lkml.org 
[lkml]   [2012]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h
On Tue, Dec 18, 2012 at 11:30:24AM -0600, Jacob Shin wrote:
> On Tue, Dec 18, 2012 at 06:19:15PM +0100, Borislav Petkov wrote:
> > On Mon, Dec 17, 2012 at 01:39:48PM -0600, Jacob Shin wrote:

> > > +/* internal error type */
> > > +const char * const uu_msgs[] = { "RESV", "RESV", "HWA", "RESV" };
> > > +EXPORT_SYMBOL_GPL(uu_msgs);
> >
> > Seems like those aren't used anywhere?

> > > @@ -634,6 +727,10 @@ static void decode_mc6_mce(struct mce *m)
> > >
> > > static inline void amd_decode_err_code(u16 ec)
> > > {
> > > + if (INT_ERROR(ec)) {
> > > + pr_emerg(HW_ERR "internal: %s\n", LL_MSG(ec));
> > > + return;
> > > + }
> >
> > Is this correct? I'm just confirming because I don't have the internal
> > info anymore.
> >
> > Uuh, hold on, maybe those otherwise unused uu_msgs above were meant to
> > be used here instead of the LL_MSG? IOW,
>
> >
> > pr_emerg(HW_ERR "internal: %s\n", UU_MSG(ec));
> >
> > Right?
>
> Ah, yes thats right, sorry about the typo. It looks like:
>
> Error Code Error Code Type Description
> 0000 01UU 0000 0000 Internal Unclassified UU = Internal Error Type
>
> And the UU encoding is as is in the mce_amd.h file

I think I meant to say as in uu_msgs[] above. HWA stands for
"Hardware Assertion" ..



\
 
 \ /
  Last update: 2012-12-18 20:01    [W:0.079 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site