Messages in this thread | | | Date | Tue, 18 Dec 2012 17:00:09 -0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h |
| |
Em 18-12-2012 16:37, Joe Perches escreveu: > On Tue, 2012-12-18 at 19:33 +0100, Borislav Petkov wrote: >> On Tue, Dec 18, 2012 at 10:24:29AM -0800, Joe Perches wrote: >>> or without all the unnecessary parens and using char: >>> >>> pr_cont("%cBUFF parity error\n", xec == 4 ? 'I' : 'O'); >> >> Char is fine, the parens make this more readable when you look at it >> again after a couple of months :-). > > <shrug> > > I think the unnecessary parens make it _less_ readable > because you need to parse more stuff and it's easy to > misplace those parens.
I agree with Boris: the parenthesis at the test (xec == 4) makes it easier to read, IMO.
Regards, Mauro
| |