lkml.org 
[lkml]   [2012]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] fbdev changes for 3.8
Hi,

On Sun, Dec 16, 2012 at 12:35:37PM -0800, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [121216 09:49]:
> > * Dave Jones <davej@redhat.com> [121215 14:27]:
> > > On Sat, Dec 15, 2012 at 01:11:04PM -0800, Linus Torvalds wrote:
> > > > On Fri, Dec 14, 2012 at 2:22 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > > > > Hi Linus,
> > > > >
> > > > > Florian, the fbdev maintainer, has been very busy lately, so I offered to send
> > > > > the pull request for fbdev for this merge window.
> > > >
> > > > Pulled. However, with this I get the Kconfig question
> > > >
> > > > OMAP2+ Display Subsystem support (OMAP2_DSS) [N/m/y/?] (NEW)
> > > >
> > > > which doesn't make a whole lot of sense on x86-64, unless there's
> > > > something about OMAP2 that I don't know.
> > > >
> > > > So I'd suggest making that OMAP2_DSS be dependent on OMAP2. Or at
> > > > least ARM. Because showing it to anybody else seems insane.
> > > >
> > > > Same goes for FB_OMAP2 for that matter. I realize that it's likely
> > > > nice to get compile testing for this on x86-64 too, but if that's the
> > > > intent, we need to think about it some more. I don't think it's good
> > > > to ask actual normal users questions like this just for compile
> > > > coverage.
> > >
> > > This OMAP stuff has been creeping into x86 builds for a while.
> > > Grep from my current build config ..
> > >
> > > # CONFIG_OMAP_OCP2SCP is not set
> > > # CONFIG_KEYBOARD_OMAP4 is not set
> > > # CONFIG_OMAP2_DSS is not set
> > > # CONFIG_OMAP_USB2 is not set
> > >
> > > There was some other arm-ism that does the same that I' currently forgetting,
> > > or maybe that got fixed..
> >
> > Those are all omap internal devices and should be all marked with
> > depends on ARCH_OMAP2PLUS.
> >
> > It's a different story for external devices that may be used on other
> > architectures.
> >
> > I only came up with one reason to compile internal devices for other
> > architectures: In some cases the driver subsystem maintainer may want to
> > be able to compile test subsystem wide changes without having to compile
> > for each target separately. But for those cases it's trivial to carry a
> > compile test patch that just drops the depends Kconfig entries.
>
> And here's a patch to limit the omap drivers above to omap only.
>
> Regards,
>
> Tony
>
>
> From: Tony Lindgren <tony@atomide.com>
> Date: Sun, 16 Dec 2012 12:28:46 -0800
> Subject: [PATCH] ARM: OMAP: Fix drivers to depend on omap for internal devices
>
> These devices are not available on other architectures, so
> let's limit them to omap.
>
> If the driver subsystem maintainers want to build test
> system wide changes without building for each target,
> it's easy to carry a test patch that just strips out the
> depends entries from Kconfig files.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -6,6 +6,7 @@ menu "Bus devices"
>
> config OMAP_OCP2SCP
> tristate "OMAP OCP2SCP DRIVER"
> + depends on ARCH_OMAP2PLUS
> help
> Driver to enable ocp2scp module which transforms ocp interface
> protocol to scp protocol. In OMAP4, USB PHY is connected via
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -544,6 +544,7 @@ config KEYBOARD_OMAP
>
> config KEYBOARD_OMAP4
> tristate "TI OMAP4+ keypad support"
> + depends on ARCH_OMAP2PLUS
> select INPUT_MATRIXKMAP
> help
> Say Y here if you want to use the OMAP4+ keypad.
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -6,6 +6,7 @@ comment "USB Physical Layer drivers"
>
> config OMAP_USB2
> tristate "OMAP USB2 PHY Driver"
> + depends on ARCH_OMAP2PLUS
> select USB_OTG_UTILS
> help
> Enable this to support the transceiver that is part of SOC. This

for Keypad, PHY and OCP2SCP I would rather not as I want to use
linux-next for compile testing our stuff in all arches.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-12-17 11:43    [W:0.078 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site