Messages in this thread | | | Date | Mon, 17 Dec 2012 10:34:14 +0100 | From | Kurt Van Dijck <> | Subject | Re: [PATCH 1/9] can: add tx/rx LED trigger support |
| |
On Mon, Dec 17, 2012 at 08:28:48AM +0100, Bernd Krumboeck wrote: > Hello Fabio! > > Am 2012-12-16 12:08, schrieb Fabio Baltieri: > >This patch implements the functions to add two LED triggers, named > ><ifname>-tx and <ifname>-rx, to a canbus device driver. > > > >Triggers are called from specific handlers by each CAN device driver and > >can be disabled altogether with a Kconfig option. > > > >The implementation keeps the LED on when the interface is UP and blinks > >the LED on network activity at a configurable rate. > > > >This only supports can-dev based drivers, as it uses some support field > >in the can_priv structure. > > > >Supported drivers should call devm_can_led_init() and can_led_event() as > >needed. > > > >Cleanup is handled automatically by devres, so no *_exit function is > >needed. > > > >Supported events are: > >- CAN_LED_EVENT_OPEN: turn on tx/rx LEDs > >- CAN_LED_EVENT_STOP: turn off tx/rx LEDs > >- CAN_LED_EVENT_TX: trigger tx LED blink > >- CAN_LED_EVENT_RX: trigger tx LED blink > > Why there is no patch for any usb can device? > > Can this be done in a more general way, except patching every driver?
There must be a way. Up to this series, there were a few minor problems: * determine if a CAN device is can_dev based * led trigger calls.
After this series, I think it's possible to make this functionality generic. But up to then, this per-driver code is a working model.
Kind regards, Kurt
| |