Messages in this thread | | | Date | Mon, 17 Dec 2012 22:42:23 +0100 | From | Fabio Baltieri <> | Subject | Re: [PATCH 1/9] can: add tx/rx LED trigger support |
| |
On Mon, Dec 17, 2012 at 09:20:57PM +0100, "Bernd Krumböck" wrote: > > If you think it's useful for USB controller, just tell me or modify the > > driver by yourself! As you see the patch is really easy. > > At least it is useful for the usb_8dev driver. I'll write a patch. > > Photo of the device: > http://www.8devices.com/product/2/usb2can
Sure that it's needed? That status LED is probably controlled directly by the firmware itself. Anyway I think it makes sense to support all the mainline drivers and I'm really happy if you test the patch on your hardware!
My only suggestion is to keep the LED support on a separate patch from the "add driver" one.
Cheers, Fabio
-- Fabio Baltieri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |