Messages in this thread Patch in this message | | | From | (Eric W. Biederman) | Date | Mon, 17 Dec 2012 17:19:36 -0800 | Subject | [PATCH] efi: Fix the build with user namespaces enabled. |
| |
When compiling efivars.c the build fails with:
CC drivers/firmware/efivars.o drivers/firmware/efivars.c: In function ‘efivarfs_get_inode’: drivers/firmware/efivars.c:886:31: error: incompatible types when assigning to type ‘kgid_t’ from type ‘int’ make[2]: *** [drivers/firmware/efivars.o] Error 1 make[1]: *** [drivers/firmware/efivars.o] Error 2
Fix the build error by removing the duplicate initialization of i_uid and i_gid inode_init_always has already initialized them to 0.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> --- drivers/firmware/efivars.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 52c5d89..7b1c374 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -883,7 +883,6 @@ static struct inode *efivarfs_get_inode(struct super_block *sb, if (inode) { inode->i_ino = get_next_ino(); - inode->i_uid = inode->i_gid = 0; inode->i_mode = mode; inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; switch (mode & S_IFMT) { -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |