Messages in this thread | | | Date | Mon, 17 Dec 2012 17:11:40 -0800 | Subject | Re: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU | From | Yinghai Lu <> |
| |
On Mon, Dec 17, 2012 at 3:26 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Mon, Dec 17, 2012 at 3:11 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> On 12/17/2012 02:47 PM, Yinghai Lu wrote: >>> >>> >>> Peter, can you check that branch again? >>> >>> I moved the early_trap_init after init_mem_mapping. >>> so for 64bit native, init_mem_mapping will setup page table for ram from >>> blank. >>> >> >> Looks better, at first glance at least. There are a couple of unnecessary >> changes (the counter in head_64.S cannot exceed 32 bits once computed, so >> the change from %rcx to %ecx change is pointless.) > > ok, return to use %ecx > >> >> There is another bug in my patch: it either needs to mask off the NX bit if >> we are running on non-NX-enabled hardware, or it needs to not set the NX bit >> (which is mostly okay that early on, I suspect.) > > i test that in kvm guest, and westmere, current version seem ok. > > will repost the patchset to list to get more review. >
not sure if i could move that early_trap_init down.
jason,
We need to move down early_trap_init after init_memory_mapping to use early #PF handler to set page table.
So can we do that? for kgdb it is that ok to move it down?
or can we just move set_intr_gate(X86_TRAP_PF, &page_fault) back to trap_init?
Thanks
Yinghai
| |