lkml.org 
[lkml]   [2012]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/microcode] x86/microcode_intel_early.c: Early update ucode on Intel's CPU
On 12/17/2012 02:47 PM, Yinghai Lu wrote:
>
> Peter, can you check that branch again?
>
> I moved the early_trap_init after init_mem_mapping.
> so for 64bit native, init_mem_mapping will setup page table for ram from blank.
>

Looks better, at first glance at least. There are a couple of
unnecessary changes (the counter in head_64.S cannot exceed 32 bits once
computed, so the change from %rcx to %ecx change is pointless.)

There is another bug in my patch: it either needs to mask off the NX bit
if we are running on non-NX-enabled hardware, or it needs to not set the
NX bit (which is mostly okay that early on, I suspect.)

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2012-12-18 01:01    [W:0.136 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site