Messages in this thread | | | Date | Sun, 16 Dec 2012 21:42:40 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() |
| |
Hi Viresh,
On Sun, Dec 16, 2012 at 06:35:24PM +0530, Viresh Kumar wrote: > On 16 December 2012 18:10, Russell King - ARM Linux > <linux@arm.linux.org.uk> wrote: > > Well, there's my comment against patch 2 which never got a reply: > > > > "Again, what about stuff not using drivers/clk/clk.c ?" > > > > Has this been addressed? > > Hmm.. I misread it and thought it is same as breaking other platforms > because there are > no dummy routines. But i was wrong :( > > So, the problem is, platform not using common-clock framework uses > this routine, and they > don't want it to be dummy but call prepare & enable.. > > Because Dmirty requires this one to be non-inline, either he can move > these routines to > drivers/clk/clk-devres.c (which would be wrong) or can add wrappers > over them in clk-devres > file.
They do not _have_ to be non-inline, I think we should simply drop the first 2 patches and I will refresh and ressend the 3rd one.
Thanks.
-- Dmitry
| |