lkml.org 
[lkml]   [2012]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] iio: adc: ad7266: Don't set error code to st->vref_uv
On 12/14/2012 08:47 AM, Axel Lin wrote:
> regulator_get_voltage() may return negative error code.
> Add error checking to avoid setting error code to st->vref_uv.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Thanks Axel, for the whole series:
Acked-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
> drivers/iio/adc/ad7266.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
> index a6f4fc5..e36107d 100644
> --- a/drivers/iio/adc/ad7266.c
> +++ b/drivers/iio/adc/ad7266.c
> @@ -411,7 +411,11 @@ static int __devinit ad7266_probe(struct spi_device *spi)
> if (ret)
> goto error_put_reg;
>
> - st->vref_uv = regulator_get_voltage(st->reg);
> + ret = regulator_get_voltage(st->reg);
> + if (ret < 0)
> + goto error_disable_reg;
> +
> + st->vref_uv = ret;
> } else {
> /* Use internal reference */
> st->vref_uv = 2500000;



\
 
 \ /
  Last update: 2012-12-14 11:41    [W:0.217 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site