Messages in this thread Patch in this message | | | Subject | [PATCH 5/6] iio: dac: ad5686: Don't set error code to voltage_uv | From | Axel Lin <> | Date | Fri, 14 Dec 2012 15:54:04 +0800 |
| |
regulator_get_voltage() may return negative error code. Add error checking to avoid setting error code to voltage_uv.
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/iio/dac/ad5686.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c index bc92ff9..28f2e59 100644 --- a/drivers/iio/dac/ad5686.c +++ b/drivers/iio/dac/ad5686.c @@ -332,7 +332,11 @@ static int __devinit ad5686_probe(struct spi_device *spi) if (ret) goto error_put_reg; - voltage_uv = regulator_get_voltage(st->reg); + ret = regulator_get_voltage(st->reg); + if (ret) + goto error_disable_reg; + + voltage_uv = ret; } st->chip_info = -- 1.7.9.5
| |